Skip to content

Conversation

@pdgendt
Copy link
Contributor

@pdgendt pdgendt commented Nov 6, 2025

Print a compliance warning if a modified file is not licensed under Apache-2.0.

Missing license files are now turned into compliance errors.

@pdgendt pdgendt requested a review from kartben November 6, 2025 12:54
paths,
"License may not be allowed",
"warning",
"error",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like an unrelated change? We'd first need to add all okay-ish license to /LICENSES until we can turn this into an error?

Copy link
Contributor Author

@pdgendt pdgendt Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the PR was a draft for that reason, the intention is to add the allowed licenses alongside that change.

But I wanted to get some feedback first 🙂

EDIT: License files added

@pdgendt pdgendt force-pushed the license-apache-missing branch from f9e97ce to 7f9c2a6 Compare November 6, 2025 13:43
@pdgendt pdgendt requested a review from nashif November 6, 2025 13:44
@pdgendt pdgendt force-pushed the license-apache-missing branch from 7f9c2a6 to 1e40022 Compare November 6, 2025 13:46
Print a compliance warning if a modified file is not licensed under
Apache-2.0.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Add license files for the reuse tool, downloaded using reuse download.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Increase the severity if a file is licensed without it being allowed.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
@pdgendt pdgendt force-pushed the license-apache-missing branch from 1e40022 to 5f7a0e3 Compare November 6, 2025 13:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants