sys: util: remove extra call in WAIT_FOR #98998
Open
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Base OS
added 2 commits
November 6, 2025 13:30
Test WAIT_FOR calls `expr` the expected number of times. Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
WAIT_FOR calls `expr` after it has evaluated to true. Store `expr` in a variable and return it instead to prevent the additional `expr` call. Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
jeppenodgaard
force-pushed
the
wait-for-improvement
branch
from
c40f775 to
5c36fab
Compare
|
teburd
approved these changes
Nov 6, 2025
maass-hamburg
approved these changes
Nov 6, 2025
|
Assigned myself as I added the macro and maintain this little bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAIT_FOR calls
exprafter it has evaluated to true.Store
exprin a variable and return it instead to prevent the additionalexprcall.