[Backport v3.7-branch] net: icmp: Verify the address family before calling the callback #98985
+162
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the address family of the packet before passing it to a ICMP handler, to avoid scenarios where ICMPv4 packet is paseed to a ICMPv6 handler and vice versa. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no> (cherry picked from commit 587d9e6)
Add test cases that respective ICMPv4/ICMPv6 handlers are not called for packets where address family doesn't match (i.e. malformed ICMPv4 packet imitating ICMPv6 one). Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no> (cherry picked from commit 486e824)
|
jukkar
approved these changes
Nov 6, 2025
maass-hamburg
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport from #98780
Fixes #98936