-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Add RV3032 MFD drive to expose Timer counter and Temperature sensor #98918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bogdanovs
wants to merge
11
commits into
zephyrproject-rtos:main
Choose a base branch
from
bogdanovs:sbogdanov/rv-3032-mfd-counter-sensor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add RV3032 MFD drive to expose Timer counter and Temperature sensor #98918
bogdanovs
wants to merge
11
commits into
zephyrproject-rtos:main
from
bogdanovs:sbogdanov/rv-3032-mfd-counter-sensor
+1,428
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d3e031 to
89100ef
Compare
Add MFD driver for managing rv3032 functionality which did not fit RTC api. That way are implemented part which otherwise will not be used: - RTC - counter/timer - temperature sensor Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
Add dependecy for MFD driver and remove I2C dependency since it will be managed from MFD driver together with interrupts. Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
Remove gpio-int since interrupts will be managed from MFD driver insted, acticting like dispatcher for interrupts. Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
Remove backup flag from RTC driver and move it to parent instead. RTC driver still can access the values of the flags but MFD need to know what is expected in term of initial behaviour. Some assumptions done in RTC driver are causing inconsistant behaviour. We cannot assume that the RTC alarms and notifications need to be cleaned only if POR bit is triggered. We can have situation where whole system go throigh soft restart and need to zero RV3032, so driver need to have option to allow that kind of behaviour. Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
Rework rv3032 implementaion to use MFD driver unstead of local implementaion for I2C access and Interrupt managements. This way could be utilized parts which are not implemented because did not fit in to RTC api - counter and temperature sensor. To have propper sincronization arbitration is need which is handled from mfd_rv3032. Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
Expose timer functionality from rv-3032-c7 via counter api. I2C communication and IRQs are arbitrated via MFD parent driver for rtc, sensor and counter at once. Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
Expose internal temperature sensor for rv-3032-c7. Driver is reporting temperature from internal deice sensors and have HIGH an LOW temperature treshhold which are triggering interrupts. I2C communication and IRQ are handled from parent MFD driver. Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
Update rv3032 to reflect latest chanes to the driver. Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
Ensure this driver is tested in the build_all test suite. Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
Ensure this driver is tested in the build_all test suite. Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
Add missing new line before channel entry for fdc2x1x which was causing CI fail Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
9c5c0c9 to
b92dd25
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



This PR introduce MFD driver for RV3032 to expose Temperature sensor and Timer counter.
RV3032 RTC driver changes:
mfd_rv3032prefixed functions from MFD guarded from semaphor