zephyrSerial: Redesign to supporting hardware serial #64
Conversation
soburi
force-pushed
the
hardware_serial
branch
from
3a07220 to
c3a0e5d
Compare
| ```sh | ||
| $> west build -p -b arduino_nano_33_ble sample/serial_event/ | ||
|
|
||
| $> west flash --bossac=/home/$USER/.arduino15/packages/arduino/tools/bossac/1.9.1-arduino2/bossac |
There was a problem hiding this comment.
close code ticks after this .. ```
soburi
force-pushed
the
hardware_serial
branch
from
c3a0e5d to
f9898d9
Compare
It is no needed. |
DhruvaG2000
left a comment
DhruvaG2000
left a comment
There was a problem hiding this comment.
Built locally, yet to test on HW, but code LGTM
|
This is a major PR in serial, and it would be awesome to have @szczys review it as well. |
Add implementations for adruino::Print functions.
Add support for the hardware serial device. The implementation using the UART interrupt, enabling CONFIG_UART_INTERRUPT_DRIVEN. Instantiate as 'Serial' with UART device defined in 'serials' array under zephyr,user node. If the 'serials' array is not defined, try to instantiate with a UART device labeled 'arduino_serial'. If even 'arduino_serial' does not define, it uses the stub implementation that redirects to printk().
Add a sample to demonstrate how to use Serial APIs
Add a description for `serials`
soburi
force-pushed
the
hardware_serial
branch
from
572a6a6 to
95d9627
Compare
szczys
left a comment
szczys
left a comment
There was a problem hiding this comment.
I read through the commit and this LGTM. I didn't have the chance to do a deep dive into everything, @DhruvaG2000 do you have any remaining concerns with this PR?
None, Thanks alot @soburi for this PR and Mike for reviewing! Apologies for the delay in merging. |
resolves: zephyrproject-rtos#64 Removed the pins logical Arduino pins 11-13 from the PWM pin list, plus their defines for the timers. With these defines in place, the pins Alternate Function settings were set to that of the timers versus the SPI value (5) Note: This was done by @mjs513 and myself.
3 participants
Add support for the hardware serial device. The implementation
using the UART interrupt, enabling CONFIG_UART_INTERRUPT_DRIVEN.
Instantiate as 'Serial' with UART device defined in 'serials' array
under zephyr,user node. If the 'serials' array is not defined,
try to instantiate with a UART device labeled 'arduino_serial'.
If even 'arduino_serial' does not define, it uses the stub
implementation that redirects to printk().
As a result of this PR, changes Serial output goes to UART1(exporse in Arduino header) in nrf52840dk_nrf52840 case.