create install script for linux #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhruvaG2000
force-pushed
the
install-script
branch
2 times, most recently
from
cd952ff to
5344559
Compare
szczys
requested changes
Sep 11, 2022
Member
szczys
left a comment
szczys
left a comment
There was a problem hiding this comment.
This is a great usability improvement, nice work!
I've made a few small suggestions for better script performance.
DhruvaG2000
force-pushed
the
install-script
branch
from
ea90925 to
e90b6f0
Compare
* assumes install script runs in module dir * Based on https://stackoverflow.com/questions/48344624/echo-prints-n-differently-between-bin-sh-and-bin-bash recommended is to use printf, hence used instead of echo. * Has confirmation qns in beginning This is to make sure the user has satisfied criterion to run the script successfully Co-authored-by: Mike Szczys <szczys@users.noreply.github.com> Signed-off-by: Dhruva Gole <goledhruva@gmail.com>
Signed-off-by: Dhruva Gole <goledhruva@gmail.com>
DhruvaG2000
force-pushed
the
install-script
branch
from
1213d68 to
b9943a2
Compare
Member
|
@DhruvaG2000 I tested out the updates to the install script and everything LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing this module will become a lot easier, the user just has to run this script and start using the module!
Signed-off-by: Dhruva Gole goledhruva@gmail.com