Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix encryption config ID backward compatibility #244

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

kobzonega
Copy link
Contributor

@kobzonega kobzonega commented Aug 26, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The ID in encryption config was sha256 hash from Storage name before 0.5.23. After changes in this PR there is just Database name now

What is the new behavior?

  • generate encyption config with ID value of sha256 hash from Storage name for backward compatibility

Other information

@kobzonega kobzonega requested a review from nikitka August 26, 2024 17:20
@kobzonega kobzonega merged commit ada0a42 into master Aug 28, 2024
7 of 8 checks passed
@kobzonega kobzonega deleted the fix-encryption-id branch August 28, 2024 13:19
kobzonega added a commit that referenced this pull request Sep 26, 2024
* fix encryption config ID backward compatibility

* revert database encryption key secret path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants