Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cms operation #240

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Cms operation #240

merged 2 commits into from
Jul 17, 2024

Conversation

kobzonega
Copy link
Contributor

@kobzonega kobzonega commented Jul 17, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Create child context WithTimeout to use with YDB grpc connection open and CMS requests
  • CMS Operation type
  • Use metav1.ConditionFalse for Failed CMS Operation and metav1.ConditionUnknown for InProgress CMS Operation

From api conventions

Condition type names should describe the current observed state of the resource, rather than describing the current state transitions. This typically means that the name should be an adjective ("Ready", "OutOfDisk") or a past-tense verb ("Succeeded", "Failed") rather than a present-tense verb ("Deploying"). Intermediate states may be indicated by setting the status of the condition to Unknown.

Other information

@kobzonega kobzonega force-pushed the cms-operation branch 2 times, most recently from 03bb33b to cab49d0 Compare July 17, 2024 09:14
@kobzonega kobzonega requested a review from bma13 July 17, 2024 14:00
@kobzonega kobzonega merged commit 0642f3f into master Jul 17, 2024
8 checks passed
@kobzonega kobzonega deleted the cms-operation branch July 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants