add TLS support for status service #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobzonega
reviewed
Jun 13, 2024
| @@ -168,6 +168,36 @@ func (b *DatabaseStatefulSetBuilder) buildVolumes() []corev1.Volume { | |||
| volumes = append(volumes, buildTLSVolume(interconnectTLSVolumeName, b.Spec.Service.Interconnect.TLSConfiguration)) | |||
| } | |||
|
|
|||
| if b.Spec.Service.Status.TLSConfiguration.Enabled { | |||
| volumes = append(volumes, | |||
| // No CA here | |||
There was a problem hiding this comment.
We should use buildTLSVolume here. In case of user hasn't CA file he may set it to just cert file
| @@ -212,6 +212,36 @@ func (b *StorageStatefulSetBuilder) buildVolumes() []corev1.Volume { | |||
| volumes = append(volumes, buildTLSVolume(interconnectTLSVolumeName, b.Spec.Service.Interconnect.TLSConfiguration)) | |||
| } | |||
|
|
|||
| if b.Spec.Service.Status.TLSConfiguration.Enabled { | |||
| volumes = append(volumes, | |||
| // No CA here | |||
There was a problem hiding this comment.
the same as database_statefulset.go, use buildTLSVolume here
nikitka
force-pushed
the
status-tls
branch
2 times, most recently
from
3b02f60 to
32c4f4b
Compare
nikitka
added
ok-to-test
kobzonega
approved these changes
Jun 17, 2024
kobzonega
pushed a commit
to kobzonega/ydb-kubernetes-operator
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Add support for Service.Status.TLSConfiguration for Storage and Database object.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information