YDBOPS-9679 dynconfig CMS ReplaceConfig #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmerkulov
reviewed
Jun 18, 2024
nmerkulov
reviewed
Jun 18, 2024
internal/cms/dynconfig.go
Outdated
| ydb.MergeOptions(opts...), | ||
| ) | ||
| if err != nil { | ||
| logger.Error(err, "Error connecting to YDB storage") |
There was a problem hiding this comment.
то же самое, что и с другим коннектом
nmerkulov
reviewed
Jun 18, 2024
|
few nits overall lgtm |
Bump chart version up to 0.5.16
…/statefulset-name" (#172)
This reverts commit 90969e2.
* use statefulset status instead of list pod by labels * fix missing "ydb.tech/remote-cluster" label * bump helm chart version
* ignore CREATE event from owns objects * unit-test detect StatefulSet delete event * compare only lastApplied annotation * fix misspell lint * bump helm chart version
* use concurrency group * using gotestsum * retry docker pull kube-webhook-certgen
artgromov
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: YDBOPS-9679
What is the new behavior?
.configfield without changes from dynconfig into ConfigMap as static configOther information