Skip to content

Add Database.Spec CABundle and Secrets options, fix Database.Spec.Path getters #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 20, 2023
Merged

Add Database.Spec CABundle and Secrets options, fix Database.Spec.Path getters #112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ba6137d
add CABundle
artgromov Feb 17, 2023
7312ff1
rearrange fields
artgromov Feb 17, 2023
2cbb7e7
add Secrets
artgromov Feb 17, 2023
f192f8b
fix database path getters
artgromov Feb 17, 2023
92e3a38
fix
artgromov Feb 17, 2023
b0666b5
fix goconst linter, comment prealloc linter
artgromov Feb 17, 2023
1b45283
fix null pointer dereference
artgromov Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix goconst linter, comment prealloc linter
  • Loading branch information
@artgromov
artgromov committed Feb 17, 2023
commit b0666b5473843bbb636d530d12dc4029265cc358
2 changes: 1 addition & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ linters:
# - nilnil
# - nlreturn
- nolintlint
- prealloc
# - prealloc
- predeclared
- rowserrcheck
- revive
Expand Down
2 changes: 1 addition & 1 deletion internal/resources/database_statefulset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ func (b *DatabaseStatefulSetBuilder) buildCaStorePatchingInitContainerArgs() ([]
}

if arg != "" {
arg += "update-ca-certificates"
arg += updateCACertificatesBin
}

args := []string{arg}
Expand Down
2 changes: 2 additions & 0 deletions internal/resources/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ const (
datastreamsIAMServiceAccountKeyVolumeName = "datastreams-iam-sa-key"
defaultEncryptionSecretKey = "key"
defaultPin = "EmptyPin"

updateCACertificatesBin = "update-ca-certificates"
)

type ResourceBuilder interface {
Expand Down
2 changes: 1 addition & 1 deletion internal/resources/storage_statefulset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ func (b *StorageStatefulSetBuilder) buildCaStorePatchingInitContainerArgs() ([]s
}

if arg != "" {
arg += "update-ca-certificates"
arg += updateCACertificatesBin
}

args := []string{arg}
Expand Down