fix: use DC and Rack from Location for nodes #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 12, 2024
artemmufazalov
commented
Feb 12, 2024
| import type {TEvSystemStateResponse} from '../../../types/api/systemState'; | ||
| import type {PreparedNode} from './types'; | ||
|
|
||
| export const prepareNodeData = (data: TEvSystemStateResponse): PreparedNode => { |
There was a problem hiding this comment.
Although is looks similar to other nodes preparation functions, it's different endpoint - /viewer/json/sysinfo, so there should be different handler
artemmufazalov
force-pushed
the
use-dc-from-location
branch
2 times, most recently
from
6b691e4 to
129386d
Compare
artemmufazalov
commented
Feb 12, 2024
| @@ -34,7 +33,7 @@ export const FullNodeViewer = ({node, className}: FullNodeViewerProps) => { | |||
| commonInfo.push( | |||
| {label: 'Version', value: node?.Version}, | |||
| {label: 'Uptime', value: calcUptime(node?.StartTime)}, | |||
| {label: 'DC', value: node?.DataCenterDescription}, | |||
| {label: 'DC', value: node?.DataCenterDescription || node?.DC}, | |||
There was a problem hiding this comment.
DataCenterDescription has more data, but it could be empty and short DC name should be used in this case
artemmufazalov
force-pushed
the
use-dc-from-location
branch
from
129386d to
51bfcab
Compare
artemmufazalov
commented
Feb 12, 2024
| @@ -12,6 +12,8 @@ const prepareComputeNode = (node: TComputeNodeInfo, tenantName?: string) => { | |||
| TenantName: node.Tenant ?? tenantName, | |||
| SystemState: node?.Overall, | |||
| Uptime: calcUptime(node?.StartTime), | |||
|
|
|||
| DC: node.DataCenter, | |||
There was a problem hiding this comment.
We don't have Location filed in viewer/json/compute
Raubzeug
approved these changes
Feb 13, 2024
artemmufazalov
force-pushed
the
use-dc-from-location
branch
from
51bfcab to
47136a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raw data we have
DataCenterfield. However, in code we reference it asDC, also backend sort works only with field short name. So replacedDataCenterfield withDCeverywhere, useDataCenterandRackfrom nodeLocationfield, where it's possible (it's not present in/viewer/json/computeendpoint)DCandRackshould appear in Node page, in Nodes and Storage tables, also sort by DC in Nodes and Storage tables now should work properly (experiment "Use table with data load on scroll for Nodes and Storage tabs" should be turned off).Node page:
Nodes table:
Node to test UI: https://nda.ya.ru/t/se1OYEka74Uxro