-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parse logging link as default value #2036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new function to parse logging links as default values and refactors related components to use the logging parameter instead of a previously used clusterName. Key changes include:
- Introducing the getLogsLink function in src/utils/logs.ts to parse a logging JSON.
- Updating tests in src/utils/test/logs.test.ts to verify the new logging URL parsing logic.
- Refactoring interfaces and function calls in monitoring.ts, ExtendedCluster.tsx, AppWithClusters.tsx, and ExtendedTenant.tsx to replace the clusterName parameter with logging.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/utils/logs.ts | Implements getLogsLink with JSON parsing and URL update logic for logging links |
src/utils/test/logs.test.ts | Adds unit tests for the new getLogsLink functionality |
src/utils/monitoring.ts | Updates GetLogsLinkProps to use logging instead of clusterName |
src/containers/AppWithClusters/ExtendedCluster/ExtendedCluster.tsx | Refactors additional cluster/tenant props to pass logging for log link generation |
src/containers/AppWithClusters/AppWithClusters.tsx | Sets a default getLogsLink function using the newly implemented logic |
src/containers/AppWithClusters/ExtendedTenant/ExtendedTenant.tsx | Updates logs link usage to use logging instead of clusterName |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fixed |
Closes #2035
CI Results
Test Status: ✅ PASSED
📊 Full Report
Test Changes Summary ⏭️1
⏭️ Skipped Tests (1)
Bundle Size: ✅
Current: 83.22 MB | Main: 83.22 MB
Diff: +2.65 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information