Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse logging link as default value #2036

Merged
merged 6 commits into from
Mar 24, 2025
Merged

feat: parse logging link as default value #2036

merged 6 commits into from
Mar 24, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Mar 21, 2025

Closes #2035

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
278 277 0 0 1
Test Changes Summary ⏭️1

⏭️ Skipped Tests (1)

  1. Streaming query shows some results and banner when stop button is clicked (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 83.22 MB | Main: 83.22 MB
Diff: +2.65 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new function to parse logging links as default values and refactors related components to use the logging parameter instead of a previously used clusterName. Key changes include:

  • Introducing the getLogsLink function in src/utils/logs.ts to parse a logging JSON.
  • Updating tests in src/utils/test/logs.test.ts to verify the new logging URL parsing logic.
  • Refactoring interfaces and function calls in monitoring.ts, ExtendedCluster.tsx, AppWithClusters.tsx, and ExtendedTenant.tsx to replace the clusterName parameter with logging.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/utils/logs.ts Implements getLogsLink with JSON parsing and URL update logic for logging links
src/utils/test/logs.test.ts Adds unit tests for the new getLogsLink functionality
src/utils/monitoring.ts Updates GetLogsLinkProps to use logging instead of clusterName
src/containers/AppWithClusters/ExtendedCluster/ExtendedCluster.tsx Refactors additional cluster/tenant props to pass logging for log link generation
src/containers/AppWithClusters/AppWithClusters.tsx Sets a default getLogsLink function using the newly implemented logic
src/containers/AppWithClusters/ExtendedTenant/ExtendedTenant.tsx Updates logs link usage to use logging instead of clusterName

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@astandrik
Copy link
Collaborator Author

fixed

@astandrik astandrik added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit 74f7a58 Mar 24, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2035 branch March 24, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: parse logging link as default value
2 participants