Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kind export operations type #2030

Merged
merged 2 commits into from
Mar 20, 2025
Merged

fix: kind export operations type #2030

merged 2 commits into from
Mar 20, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Mar 20, 2025

Closes #2029

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
264 263 0 0 1
Test Changes Summary ⏭️1

⏭️ Skipped Tests (1)

  1. Streaming query shows some results and banner when stop button is clicked (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 83.22 MB | Main: 83.22 MB
Diff: 1.47 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the export operation kind identifier from "export" to "export/s3" for better specificity and consistency.

  • Changed the operation kind in the constants file along with its localization key.
  • Updated the OperationKind type in the API types file.
  • Modified the zod schema in the query parameters hook to validate the new kind.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
src/containers/Operations/constants.ts Updated operation kind value and localization key for export operations.
src/types/api/operations.ts Revised OperationKind union to replace "export" with "export/s3".
src/containers/Operations/useOperationsQueryParams.ts Adjusted zod enum values to validate "export/s3".
Files not reviewed (1)
  • src/containers/Operations/i18n/en.json: Language not supported
artemmufazalov
artemmufazalov previously approved these changes Mar 20, 2025
@astandrik astandrik added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 3b47eb5 Mar 20, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2029 branch March 20, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: kind export operations type
2 participants