feat: followerId for tablets #2025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for displaying a follower identifier alongside tablet IDs across several UI components. The changes update SQL queries and component props to concatenate the follower identifier (if available) into the tablet name displayed in tablet-related views.
- Updated SQL query alias from "Path" to "RelativePath" and switched to wildcard selection for partition stats.
- Modified Tablet.tsx and TabletNameWrapper.tsx to incorporate a new followerId field in tablet naming.
- Updated TabletsTable.tsx and ShardsTable/columns.tsx to pass and render the followerId accordingly.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/store/reducers/shardsWorkload/shardsWorkload.ts | Updated query to alias path as "RelativePath" and use wildcard selection from .sys/partition_stats, aligning schema field names with UI components. |
| src/containers/Tablet/Tablet.tsx | Added extraction of FollowerId from tablet data and updated tablet name construction for better identification. |
| src/components/TabletNameWrapper/TabletNameWrapper.tsx | Extended component props and tablet name concatenation to support an additional followerId field. |
| src/containers/Tablets/TabletsTable.tsx | Modified usage of TabletNameWrapper to pass followerId from tablet rows. |
| src/components/ShardsTable/columns.tsx | Updated column rendering to use new "RelativePath" alias and pass followerId to TabletNameWrapper. |
Comments suppressed due to low confidence (1)
src/store/reducers/shardsWorkload/shardsWorkload.ts:80
- Using wildcard selection may unintentionally include extra columns; consider explicitly listing only the necessary fields to ensure that downstream processing remains consistent.
`.sys/partition_stats`.*
artemmufazalov
requested changes
Mar 18, 2025
| database?: string; | ||
| } | ||
|
|
||
| export function TabletNameWrapper({tabletId, database}: TabletNameWrapperProps) { | ||
| export function TabletNameWrapper({tabletId, followerId, database}: TabletNameWrapperProps) { | ||
| const isUserAllowedToMakeChanges = useIsUserAllowedToMakeChanges(); | ||
|
|
||
| const tabletPath = getTabletPagePath(tabletId, {database}); |
There was a problem hiding this comment.
FollowerId should be in page path as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1479
Stand
CI Results
Test Status: ✅ PASSED
📊 Full Report
Test Changes Summary ⏭️1
⏭️ Skipped Tests (1)
Bundle Size: ✅
Current: 83.22 MB | Main: 83.22 MB
Diff: +3.39 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information