fix(ShemaViewer): show loader correctly #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
reviewed
Mar 18, 2025
| const viewSchemaRequestParams = isViewType(type) ? {path, database: tenantName} : skipToken; | ||
|
|
||
| const {data: viewColumnsData, isLoading: isViewSchemaLoading} = | ||
| const {currentData: viewColumnsData, isLoading: isViewSchemaLoading} = |
There was a problem hiding this comment.
actually we can still use data - as it will update as soon as data fetched
There was a problem hiding this comment.
It is not properly updated when you change objects in schema tree. So you have a chance to see data of a previous object until current object data is loaded
There was a problem hiding this comment.
You can try it here - change schema object from my_view3 to my_view2 with slowed internet
There was a problem hiding this comment.
I mean we have
if (loading || isViewSchemaLoading) {
return <TableSkeleton />;
}
I would expect that until data is fully loaded/fetched we would see skeleton?
astandrik
previously approved these changes
Mar 18, 2025
artemmufazalov
commented
Mar 19, 2025
Comment on lines
+54
to
+56
| const loading = | ||
| (isViewSchemaFetching && viewColumnsData === undefined) || | ||
| (isTableSchemaFetching && tableSchemaData === undefined); |
There was a problem hiding this comment.
isLoading isn't set to true when path changes, so we don't see loader on schema object change
astandrik
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1288
CI Results
Test Status: ✅ PASSED
📊 Full Report
Test Changes Summary ⏭️1
⏭️ Skipped Tests (1)
Bundle Size: ✅
Current: 83.22 MB | Main: 83.22 MB
Diff: +0.25 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information