feat: query streaming only for queryService #2015
Merged
+38
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
commented
Mar 17, 2025
| @@ -90,30 +90,28 @@ export const QueryEditorControls = ({ | |||
| const [cancelQueryError, setCancelQueryError] = React.useState<boolean>(false); | |||
|
|
|||
| const onStopButtonClick = React.useCallback(async () => { | |||
| if (queryId) { | |||
There was a problem hiding this comment.
already have check for sendCancelQuery
There was a problem hiding this comment.
Pull Request Overview
This PR restricts query streaming functionality to occur only when using the queryService.
- In Graph.tsx, a type guard (isValidGraphData) is introduced and memoization is used for graph data.
- In QueryEditorControls.tsx, the conditional check for queryId is removed in the stop query function.
- In QueryEditor.tsx, the streaming enabled condition is updated to also check that the query mode is set to query.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/containers/Tenant/Query/QueryResult/components/Graph/Graph.tsx | Adds a type guard and useMemo call to validate and memoize graph data. |
| src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.tsx | Removes the queryId check in the stop query callback. |
| src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx | Enhances streaming enablement logic to only allow streaming in query mode. |
Comments suppressed due to low confidence (1)
src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.tsx:92
- The removal of the queryId check may lead to calling abortQuery even when queryId is not present. Please verify that the absence of queryId will not cause unintended behavior.
if (queryId) {
astandrik
commented
Mar 17, 2025
| return <StubMessage message={i18n('description.graph-is-not-supported')} />; | ||
| } | ||
|
|
||
| return ( | ||
| <div className={b('canvas-container')}> | ||
| <YDBGraph key={theme} data={{links, nodes}} /> |
There was a problem hiding this comment.
double useEffect call in YDBGraph that was leading to clearRect error on client (caught in tests)
artemmufazalov
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2011
CI Results
Test Status: ✅ PASSED
📊 Full Report
Test Changes Summary ⏭️1
⏭️ Skipped Tests (1)
Bundle Size: ✅
Current: 83.21 MB | Main: 83.21 MB
Diff: +0.43 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information