fix: fix undefined process in package

[artemmufazalov]

When ydb-embedded-ui is used as package, there is an error, that process is not defined. That's why I import package json directly

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total	Passed	Failed	Flaky	Skipped
264	261	0	2	1

Test Changes Summary ⏭️1

⏭️ Skipped Tests (1)

1. Streaming query shows some results and banner when stop button is clicked (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 80.81 MB | Main: 80.81 MB
Diff: 0.15 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information

• Test recordings for failed tests are available in the full report.
• Bundle size is measured for the entire 'dist' directory.
• 📊 indicates links to detailed reports.
• 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

[artemmufazalov]

There is no need to install it explicitly

[astandrik]

Have you tried sth like window.ui_version? the same way it is used for react_app_disable_checks

Still feel that using package.json directly may have pitfalls.

[artemmufazalov]

I tried index.html, the problem is that webpack.DefinePlugin does not expose vars to html files, so we can use them in js, but not in index.html (but all envs passed in command or taken from .env file work fine).

[sareyu]

what's wrong with this approach?

[artemmufazalov]

process.env values are embedded in build, so in build I have
version: process.env.UI_VERSION -> version: 8.11.0

However, when we use it as a package, we have only process.env.UI_VERSION in our code, when we import it and try to open in UI we receive process is not defined error, no variables are exposed

[sareyu]

LGTM

[astandrik]

Could you try this approach?

https://github.com/ydb-platform/ydb-embedded-ui/pull/2005/files

[artemmufazalov]

Could you try this approach?

https://github.com/ydb-platform/ydb-embedded-ui/pull/2005/files

Please, describe, how it should work in case of package? There is no vars from webpack.DefinePlugin there

[astandrik]

Could you try this approach?
https://github.com/ydb-platform/ydb-embedded-ui/pull/2005/files

Please, describe, how it should work in case of package? There is no vars from webpack.DefinePlugin there

You right - it wont work for package

Maybe

import {version} from './package.json';

would work?

Here is some discussion on this topic https://stackoverflow.com/questions/9153571/is-there-a-way-to-get-the-version-from-the-package-json-file-in-node-js-code

The idea of exposing entire package.json intuitively feels unsecure

However, our code is open-source and package.json is already visible in github to everyone - so its not a problem

Could we give it the last try with import {version} from './package.json'; and if it wont work - proceed with requiring the whole package.json

[artemmufazalov]

Could we give it the last try with import {version} from './package.json'; and if it wont work - proceed with requiring the whole package.json

There is another error
Should not import the named export 'version' (imported as 'version') from default-exporting module (only default export is available soon)

[artemmufazalov]

Could we give it the last try with import {version} from './package.json'; and if it wont work - proceed with requiring the whole package.json

There is another error Should not import the named export 'version' (imported as 'version') from default-exporting module (only default export is available soon)

Actually, it works, but the error is displayed

[astandrik]

Well, at least we tried :_)