Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make links from disk pop-up better #1986

Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat: make links from disk pop-up better #1986

merged 1 commit into from
Feb 28, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Feb 26, 2025 •
edited by github-actions bot
Loading

Closes #1568

Stand

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
262 262 0 0 0

😟 No changes in tests. 😕

Bundle Size: 🔺

Current: 80.68 MB | Main: 80.62 MB
Diff: +0.06 MB (0.07%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copilot
Copilot AI reviewed Feb 26, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/components/PDiskInfo/PDiskInfo.tsx:153

  • [nitpick] The removal of the styling class (via b('links')) in favor of directly rendering a Flex container might lead to inconsistent styling compared to other components. Consider applying the same styling (or equivalent classes) to the Flex container to maintain consistent UI appearance.
<span className={b('links')}>
@astandrik astandrik added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 336d74b Feb 28, 2025
8 checks passed
@astandrik astandrik deleted the astandrik.popup-links-1568 branch February 28, 2025 08:40
@ydb-platform-bot ydb-platform-bot mentioned this pull request Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Raubzeug Raubzeug Raubzeug approved these changes

@artemmufazalov artemmufazalov Awaiting requested review from artemmufazalov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make links from disk pop-up better
2 participants
@astandrik @Raubzeug