Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TabletsTable): add search by id #1981

Merged
merged 2 commits into from
Feb 25, 2025
Merged

feat(TabletsTable): add search by id #1981

merged 2 commits into from
Feb 25, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Feb 24, 2025 •
edited by github-actions bot
Loading

Closes #1465

Stand: https://nda.ya.ru/t/ALi8tv5x7CF5z8

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
262 262 0 0 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 80.62 MB | Main: 80.61 MB
Diff: +3.84 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov marked this pull request as ready for review February 24, 2025 15:18
Raubzeug
Raubzeug requested changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@Raubzeug Raubzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's make search width 238px (same as on other tabs)
  2. Let's also add label with n of m tablets (like for databases or nodes)

@artemmufazalov artemmufazalov added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit d68adba Feb 25, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the 1465-tablets-search branch February 25, 2025 11:28
@ydb-platform-bot ydb-platform-bot mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raubzeug Raubzeug Raubzeug approved these changes

@astandrik astandrik Awaiting requested review from astandrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find tablets in tablets table by ID
2 participants
@artemmufazalov @Raubzeug