fix(Node): fix developer ui link in dev mode #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Feb 24, 2025
|
|
||
| const additionalNodesProps = getAdditionalNodesProps(balancer, useClusterBalancerAsBackend); | ||
|
|
||
| return singleClusterMode ? undefined : additionalNodesProps; |
There was a problem hiding this comment.
There was no check for singleClusterMode, so useNodeDeveloperUIHref always used additionalNodesProps and formed incorrect href when app was started with REACT_APP_BACKEND
artemmufazalov
commented
Feb 24, 2025
| @@ -17,7 +16,6 @@ import './ClusterInfo.scss'; | |||
|
|
|||
| interface ClusterInfoProps { | |||
| cluster?: TClusterInfo; | |||
| versionToColor?: VersionToColorMap; | |||
There was a problem hiding this comment.
It is not used here
artemmufazalov
force-pushed
the
node-info-fix-link
branch
from
4018eec to
6b44b1e
Compare
artemmufazalov
force-pushed
the
node-info-fix-link
branch
from
6b44b1e to
846a48e
Compare
artemmufazalov
changed the title
astandrik
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 80.61 MB | Main: 80.61 MB
Diff: 0.62 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information