-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redesign query #1974
feat: redesign query #1974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 10 out of 25 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- src/components/ElapsedTime/ElapsedTime.scss: Language not supported
- src/components/QueryExecutionStatus/QueryExecutionStatus.scss: Language not supported
- src/containers/Tenant/Query/CancelQueryButton/CancelQueryButton.scss: Language not supported
- src/containers/Tenant/Query/QueryDuration/QueryDuration.scss: Language not supported
- src/containers/Tenant/Query/QueryEditorControls/EditorButton.scss: Language not supported
- src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/QueryResultViewer.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/QueryResultError/QueryResultError.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/ResultSetsViewer/ResultSetsViewer.scss: Language not supported
- src/components/ElapsedTime/ElapsedTime.tsx: Evaluated as low risk
- src/containers/Tenant/Query/CancelQueryButton/CancelQueryButton.tsx: Evaluated as low risk
- src/containers/Tenant/Query/QueryDuration/QueryDuration.tsx: Evaluated as low risk
- src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx: Evaluated as low risk
- src/components/QueryExecutionStatus/QueryExecutionStatus.tsx: Evaluated as low risk
- src/containers/Tenant/Query/QueryResult/QueryResultViewer.tsx: Evaluated as low risk
Comments suppressed due to low confidence (2)
src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.tsx:63
- Add a null check for cancelQueryResponse before calling the reset method to avoid potential runtime errors.
cancelQueryResponse.reset();
src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.tsx:104
- [nitpick] Ensure that the renderStopButton function is not called redundantly to improve code efficiency.
const renderStopButton = () => (
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If switch to Diagnostics and than back to Query, query duration starts from zero. And Run button starts animate as if query starts again.
@Raubzeug made fixes - now it should work as expected |
@@ -18,6 +18,9 @@ const config: PlaywrightTestConfig = { | |||
? undefined | |||
: { | |||
command: 'npm run dev', | |||
env: { | |||
REACT_APP_DISABLE_CHECKS: 'true', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled rtk-immutability checks for tests (in prod its disabled by default)
drastically improves stream tables performance
This reverts commit f45de0c.
Closes #1949
Stand
CI Results
Test Status: β PASSED
π Full Report
Test Changes Summary β¨5 βοΈ1 ποΈ4
β¨ New Tests (5)
βοΈ Skipped Tests (1)
ποΈ Deleted Tests (4)
Bundle Size: πΊ
Current: 80.79 MB | Main: 80.78 MB
Diff: +0.01 MB (0.01%)
βΉοΈ CI Information