Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hide some columns and storage nodes for users-viewers #1967

Merged
merged 1 commit into from
Feb 19, 2025
Merged

feat: hide some columns and storage nodes for users-viewers #1967

merged 1 commit into from
Feb 19, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Feb 19, 2025 •
edited by github-actions bot
Loading

Closes #1408

How UI will look like for users-viewers: https://nda.ya.ru/t/BAWCJ3407C7NKx

Changes for users with isMonitoringAllowed: false:

  • Hide storage nodes table and groups / nodes radio button, always display groups in storage
  • Hide Pools and Memory columns in nodes column - for this metrics will be available columns CPU and RAM
  • Hide DiskSpaceUsage, Latency, AllocationUnits, VDisksPDisks columns in storage groups table

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
262 262 0 0 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 80.46 MB | Main: 80.46 MB
Diff: +1.97 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

artemmufazalov
artemmufazalov commented Feb 19, 2025
View reviewed changes
src/utils/hooks/useIsUserAllowedToMakeChanges.ts
Comment on lines +5 to +7
export function useIsUserAllowedToMakeChanges() {
return useTypedSelector(selectIsUserAllowedToMakeChanges);
}
Copy link
Member Author

@artemmufazalov artemmufazalov Feb 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a custom hook to import one function instead of two, no changes in this part

@artemmufazalov artemmufazalov marked this pull request as ready for review February 19, 2025 10:33
@artemmufazalov artemmufazalov requested review from astandrik and Raubzeug and removed request for astandrik February 19, 2025 10:33
@artemmufazalov artemmufazalov added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 249011d Feb 19, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the 1408-limit-columns branch February 19, 2025 13:11
@ydb-platform-bot ydb-platform-bot mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raubzeug Raubzeug Raubzeug approved these changes

@astandrik astandrik Awaiting requested review from astandrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit list of column for users with viewer rights in Storage and Nodes tables
2 participants
@artemmufazalov @Raubzeug