fix(PDiskSpaceDistribution): update slots severity calculation #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Feb 4, 2025
Comment on lines
+44
to
+51
| const usagePercent = (Number(LogUsedSize) * 100) / Number(LogTotalSize); | ||
|
|
||
| logSlot = { | ||
| SlotType: 'log', | ||
| Used: Number(LogUsedSize), | ||
| Total: Number(LogTotalSize), | ||
| UsagePercent: (Number(LogUsedSize) * 100) / Number(LogTotalSize), | ||
| Severity: 1, | ||
| UsagePercent: usagePercent, | ||
| Severity: getSpaceSeverity(usagePercent), |
There was a problem hiding this comment.
Colorize log just like other slots. For example, if log is 90/100, it should be yellow, if 99/100 - red.
artemmufazalov
commented
Feb 4, 2025
Comment on lines
+69
to
+72
| const slotSeverity = Math.max( | ||
| getSpaceSeverity(preparedVDisk.AllocatedPercent), | ||
| preparedVDisk.Severity || 0, | ||
| ); |
There was a problem hiding this comment.
We don't use allocated percent to get vdisks severity inside prepare functions, we use it only here while preparing slots
artemmufazalov
commented
Feb 4, 2025
| @@ -78,7 +89,7 @@ export function preparePDiskDataResponse([pdiskResponse = {}, nodeResponse]: [ | |||
| if (ExpectedSlotCount && ExpectedSlotCount > vdisksSlots.length) { | |||
| const emptySlotsCount = ExpectedSlotCount - vdisksSlots.length; | |||
|
|
|||
| let emptySlotSize = Number(EnforcedDynamicSlotSize); | |||
| let emptySlotSize = Number(SlotSize); | |||
There was a problem hiding this comment.
There was a bug, added tests
artemmufazalov
commented
Feb 4, 2025
| @@ -17,13 +10,13 @@ export function calculatePDiskSeverity< | |||
| }, | |||
| >(pDisk: T) { | |||
| const stateSeverity = getStateSeverity(pDisk.State); | |||
| const spaceSeverityFlag = getUsageSeverityForPDisk(pDisk.AllocatedPercent || 0); | |||
| const spaceSeverity = getSpaceSeverity(pDisk.AllocatedPercent); | |||
There was a problem hiding this comment.
Just little refactoring
artemmufazalov
force-pushed
the
1812-pdisk-space-distribution
branch
from
8ffde21 to
b3c29d5
Compare
Raubzeug
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1812
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 80.20 MB | Main: 80.19 MB
Diff: +0.90 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information