fix(ClusterInfo): update links view #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Dec 10, 2024
| @@ -80,7 +61,7 @@ export const getInfo = ( | |||
| if (dataCenters?.length) { | |||
| info.push({ | |||
| label: i18n('label_dc'), | |||
| value: <Tags tags={dataCenters} gap={2} />, | |||
| value: <Tags tags={dataCenters} gap={2} className={b('dc')} />, | |||
There was a problem hiding this comment.
Set element height, so info and links sections rows have the same height
artemmufazalov
commented
Dec 10, 2024
| @@ -29,18 +26,6 @@ const COLORS_PRIORITY: Record<EFlag, number> = { | |||
| Grey: 0, | |||
| }; | |||
|
|
|||
| export const compareTablets = (tablet1: TTabletStateInfo, tablet2: TTabletStateInfo) => { | |||
There was a problem hiding this comment.
Unneeded function
artemmufazalov
commented
Dec 10, 2024
| } | ||
|
|
||
| &__metrics { |
There was a problem hiding this comment.
I didn't find usages of these classes, so I deleted them
artemmufazalov
commented
Dec 10, 2024
| return ( | ||
| <div> | ||
| <div className={b('section-title')}>{i18n('title_info')}</div> | ||
| <DefinitionList nameMaxWidth={200}> |
There was a problem hiding this comment.
200 max width is names width of InfoViewer, it will look the same as Tablet page
Raubzeug
previously approved these changes
Dec 11, 2024
| ); | ||
| }; | ||
|
|
||
| const renderLinks = () => { |
There was a problem hiding this comment.
const linksList = links.concat(clusterLinks) ?
And farther logic should become leaner.
Raubzeug
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1741
Updated cluster links view, it now looks like Tablet page
Stand (these links are invalid, it's only to display): https://nda.ya.ru/t/O2N0YNcr7AJF5c
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 65.87 MB | Main: 65.86 MB
Diff: +0.01 MB (0.02%)
ℹ️ CI Information