fix: change trace and svg mutations to lazy query #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
commented
Nov 16, 2024
| @@ -23,7 +23,7 @@ interface PlanToSvgButtonProps { | |||
| export function PlanToSvgButton({plan, database}: PlanToSvgButtonProps) { | |||
| const [error, setError] = React.useState<string | null>(null); | |||
| const [blobUrl, setBlobUrl] = React.useState<string | null>(null); | |||
| const [getPlanToSvg, {isLoading}] = planToSvgApi.usePlanToSvgQueryMutation(); | |||
| const [getPlanToSvg, {isLoading}] = planToSvgApi.useLazyPlanToSvgQueryQuery(); | |||
There was a problem hiding this comment.
thats actual changes
astandrik
commented
Nov 16, 2024
| @@ -20,7 +20,7 @@ export function TraceButton({traceId, isTraceReady}: TraceUrlButtonProps) { | |||
| const checkTraceUrl = traceCheck?.url ? replaceParams(traceCheck.url, {traceId}) : ''; | |||
| const traceUrl = traceView?.url ? replaceParams(traceView.url, {traceId}) : ''; | |||
|
|
|||
| const [checkTrace, {isLoading, isUninitialized}] = traceApi.useCheckTraceMutation(); | |||
| const [checkTrace, {isLoading, isUninitialized}] = traceApi.useLazyCheckTraceQuery(); | |||
There was a problem hiding this comment.
thats actual changes
added 3 commits
November 16, 2024 19:13
astandrik
commented
Nov 16, 2024
| @@ -27,29 +27,6 @@ test.describe('Test Query Editor', async () => { | |||
| await tenantPage.goto(pageQueryParams); | |||
| }); | |||
|
|
|||
| test('Settings dialog opens on Gear click and closes on Cancel', async ({page}) => { | |||
There was a problem hiding this comment.
moved to separate files
added 2 commits
November 17, 2024 01:29
Raubzeug
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
src/containers/Tenant/Query/ExecuteResultcomponents, updates to API endpoints, and new test cases for the sidebar and query editor functionalities. The most important changes include modifying API queries, adding new test utilities and classes, and updating existing test cases.API Query Modifications:
src/containers/Tenant/Query/ExecuteResult/PlanToSvgButton.tsx: Changed fromusePlanToSvgQueryMutationtouseLazyPlanToSvgQueryQuery.src/containers/Tenant/Query/ExecuteResult/TraceButton.tsx: Changed fromuseCheckTraceMutationtouseLazyCheckTraceQuery.src/store/reducers/planToSvg.ts: ChangedplanToSvgQueryfrom a mutation to a query.src/store/reducers/trace.ts: ChangedcheckTracefrom a mutation to a query.Test Enhancements:
tests/suites/nodes/nodes.test.ts: AddedtoggleExperimentutility and updated the test to use it for enabling paginated tables. [1] [2]tests/suites/sidebar/Sidebar.ts: Added a newSidebarclass to manage sidebar interactions in tests.tests/suites/sidebar/sidebar.test.ts: Added comprehensive tests for the sidebar, including visibility, button interactions, and experiment toggling.tests/suites/tenant/queryEditor/planToSvg.test.ts: Added a new test suite for the Plan to SVG functionality, including experiment toggling and SVG verification.tests/suites/tenant/queryEditor/queryEditor.test.ts: Moved tests for functionalities to separate files. [1] [2] [3] [4]Closes #1639
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: 🔽
Current: 66.07 MB | Main: 66.08 MB
Diff: 0.00 MB (-0.01%)
✅ Bundle size decreased.
ℹ️ CI Information