Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass database to capabilities query #1551

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Oct 28, 2024

Closes #1526

/viewer/capabilities is used on several pages and in different components. In order not to pass database param every time to hook, I made hook to take database param from search query by itself. To make it possible I named param the same way on every page where it's used

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
134 133 0 1 0

Bundle Size: 🔺

Current: 79.11 MB | Main: 79.11 MB
Diff: +0.01 MB (0.01%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov force-pushed the 1526-pass-database-to-capabilities branch 2 times, most recently from d127f27 to b137164 Compare October 29, 2024 12:30
@artemmufazalov artemmufazalov force-pushed the 1526-pass-database-to-capabilities branch from b137164 to 485c571 Compare October 29, 2024 12:36
nodeId: string | number;
backend?: string;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend is never passed here now, so I deleted it

@artemmufazalov artemmufazalov added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 7e7b3e3 Oct 29, 2024
6 checks passed
@artemmufazalov artemmufazalov deleted the 1526-pass-database-to-capabilities branch October 29, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if the database name is known call compatibilities handler with it
2 participants