fix: popup closes on context menu copy #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Raubzeug @artemmufazalov ping |
Raubzeug
requested changes
Oct 16, 2024
| @@ -0,0 +1,5 @@ | |||
| @import '../../styles/mixins.scss'; | |||
| </div> | ||
| <Popup | ||
| contentClassName={b()} | ||
| anchorRef={anchorRef || anchor} |
There was a problem hiding this comment.
Should we allow to pass anchorRef? Won't it break behaviour set by us?
There was a problem hiding this comment.
We allow to pass anchorRef for custom anchors if they are needed
if anchorRef is not passed - default anchor from component is used
Comment on lines
+65
to
+85
| const onPopupMouseEnter = React.useCallback(() => { | ||
| setIsPopupContentHovered(true); | ||
| }, []); | ||
|
|
||
| const onPopupMouseLeave = React.useCallback(() => { | ||
| setIsPopupContentHovered(false); | ||
| }, []); | ||
|
|
||
| const onPopupContextMenu = React.useCallback(() => { | ||
| setIsFocused(true); | ||
| }, []); | ||
|
|
||
| const onPopupBlur = React.useCallback(() => { | ||
| setIsFocused(false); | ||
| }, []); | ||
|
|
||
| const onPopupEscapeKeyDown = React.useCallback(() => { | ||
| setIsFocused(false); | ||
| setIsPopupContentHovered(false); | ||
| hidePopup(); | ||
| }, [hidePopup]); |
There was a problem hiding this comment.
do we really need all these useCallback?
There was a problem hiding this comment.
yes
because we pass this function as prop to external component which may use this function as prop
Raubzeug
approved these changes
Oct 16, 2024
astandrik
deleted the
astandrik.popup-closes-on-context-menu-copy-1452
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1452
Stand
Problem:
Screen.Recording.2024-10-11.at.13.58.58.mov
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 78.96 MB | Main: 78.95 MB
Diff: +0.00 MB (0.01%)
ℹ️ CI Information