feat: display all types of keys as plain text #1219
Conversation
|
|
||
| constructor(page: Page) { | ||
| this.tabs = page.locator('.kv-tenant-diagnostics__tabs'); | ||
| this.schemaViewer = page.locator('.schema-viewer__table'); |
There was a problem hiding this comment.
Not sure if understood properly
You mean to rename schemaViewer -> schemaViewerDatatable ?
There was a problem hiding this comment.
No, I mean you have this.dataTable selector, why do you need additional selector for SchemaViewer DataTable?
There was a problem hiding this comment.
This test is about schema tab, not diagnostics as whole, but it's called diagnostics (relates to Diagnostics.ts too)
Or this is supposed to be split, when new tabs are added?
There was a problem hiding this comment.
Diagnostics is a name for a set of tests for this tab
For now it's just about schema tab because I touched it and decided to write a test for it
There was a problem hiding this comment.
Not sure why named it 'table'
removed subclass
astandrik
deleted the
astandrik.display-all-types-of-keys-as-plain-text-1116
branch
Closes #1116
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 78.83 MB | Main: 78.83 MB
Diff: +0.01 MB (0.01%)
ℹ️ CI Information