Allow using closures as transformer (#1) #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original Fractal package allows closures as transformers (https://fractal.thephpleague.com/transformers/) so it would be good and useful to leave that feature SO it for example will allow folks to transform the data using Laravel API Resource like this ``` return DataTables::eloquent($query) ->setTransformer(function ($item){ return Resource::make($item)->resolve(); }) ->make(); ```
Contributor
Author
|
I'm not the only one yajra/laravel-datatables#1863 |
Owner
|
Wow, love this PR. It makes the resource integration easier. Thanks a lot! ❤️ 🍻 |
Owner
|
Released on v1.3.0. For the docs, it's located on https://github.com/yajra/laravel-datatables-docs/blob/master/response-fractal.md. Would you mind sending a PR too? Thanks! |
Contributor
Author
|
Wow! That was fast! Thank you too! |
c00p3r
added a commit
to c00p3r/laravel-datatables-docs
that referenced
this pull request
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Fractal package allows closures as transformers (https://fractal.thephpleague.com/transformers/)
so it would be good and useful to leave that feature
SO it for example will allow folks to transform the data using Laravel API Resource like this
Also, if you accept this PR, would be probably nice to update 'datatables' docs chapter 'Response > Fractal Transformer'