Update code samples with changes in version 1.8.0 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe that from version 1.8.0 onwards `creating`, `created`, `updating`, `updated`, and `saved` event hooks must return the `$model` instance. Add documentation and code sample for `saved` event hook. Remove `return $data` from `deleting` and `deleted` code samples, and instead add comment on what the code may do on each case.
Add PHPDoc blocks to sample code. `creating`, `updating`, and `saving` must always return `$data` array.
Owner
Author
|
OK, if you decide to revert the changes, I will update this PR accordingly. |
Owner
|
Sorry for late reply, I think we can stick to the changes on PR and update the docs accordingly. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe that from version 1.8.0 onwards
creating,created,updating,updated, andsavedevent hooks must return the$modelinstance.
Add documentation and code sample for
savedevent hook.Remove
return $datafromdeletinganddeletedcode samples, andinstead add comment on what the code may do on each case.
Closes #52 #