Skip to content

Conversation

@dcherian
Copy link
Contributor

@dcherian dcherian commented Aug 28, 2024

@vercel
Copy link

vercel bot commented Aug 28, 2024

@dcherian is attempting to deploy a commit to the xarray Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xarray-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 3:19am

@dcherian dcherian marked this pull request as ready for review September 3, 2024 19:15
@dcherian dcherian requested a review from max-sixty September 3, 2024 19:15
@max-sixty
Copy link

Looks good!

I guess it would be a bit more instructive to have some more than one value on each index — at the moment the result is a diagonal, which is fine but less "oh cool!".

But ofc still good in its current state. And again — the feature is a big step forward for xarray, thank you!

@dcherian dcherian merged commit 367cbe7 into xarray-contrib:main Sep 11, 2024
@dcherian dcherian deleted the multiple-groupers branch September 11, 2024 18:47
dcherian added a commit that referenced this pull request Nov 12, 2024
* upstream/main:
  Fix hydration warning due to nested links (#725)
  Bump typescript from 5.6.2 to 5.6.3 (#724)
  [pre-commit.ci] pre-commit autoupdate (#720)
  Bump webpack from 5.95.0 to 5.96.1 (#723)
  Bump the dev-dependencies group across 1 directory with 4 updates (#719)
  Bump webpack from 5.94.0 to 5.95.0 (#718)
  Bump @fontsource-variable/inter from 5.0.20 to 5.1.0 (#717)
  Bump typescript from 5.5.4 to 5.6.2 (#716)
  Bump the dependencies group with 9 updates (#714)
  Bump next from 14.2.7 to 14.2.10 (#711)
  Turn off survey banner (#710)
  Update opengraph thumbnails (#709)
  GroupBy(multiple variables) (#703)
  Bump webpack from 5.93.0 to 5.94.0 (#704)
  Bump micromatch from 4.0.7 to 4.0.8 (#707)
  Bump the dependencies group with 7 updates (#705)
  Bump the dev-dependencies group with 4 updates (#706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants