Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Swiper component modifies skyline rendering mode #162

Merged
merged 7 commits into from
Mar 18, 2025

Conversation

bailin0824
Copy link
Contributor

No description provided.

}
},
selectionChangeHandler(e) {
const selection = e.detail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件的缩进有问题

@@ -0,0 +1,29 @@
Page({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cover-image 不用加,有了同层渲染大部分场景都不需要 cover-* 组件,并且 cover-* 组件没有太多可展示的能力

@@ -72,7 +74,7 @@
"ignore": [],
"include": []
},
"appid": "wxe5f52902cf4de896",
"appid": "wx622bee4f78fa4f5a",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appid 不要改动

<rich-text id="rich-text-1" user-select="{{true}}">rich-text</rich-text>
<rich-text id="rich-text-2" user-select="{{true}}" nodes="{{htmlSnip}}"></rich-text>
</selection>
<text id="before-text" user-select="{{true}}">在 wx-selection 之后的 text</text>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉 wx-,正式组件名是 selection

@@ -0,0 +1,28 @@
.scroll-area {
flex: 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码缩进不对

<button wx:if="{{canIUseGetUserProfile}}" type="primary" lang="zh_CN" bindtap="handleGetUserProfile"> 获取用户信息 </button>
<button wx:else type="primary" open-type="getUserInfo" lang="zh_CN" bindgetuserinfo="handleGetUserInfo">获取用户信息</button>
<button type="primary" open-type="chooseAvatar" bindchooseavatar="handleChooseavatar">获取用户头像</button>
<button type="primary" open-type="launchApp" app-parameter="wechat" binderror="launchAppError">打开APP</button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该打开不了,可以去掉

@@ -0,0 +1,29 @@
Page({
onShareAppMessage() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码缩进不统一,统一两个空格

@@ -0,0 +1,99 @@
Page({
onShareAppMessage() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码缩进不统一

handleChooseavatar(e) {
console.log('handleChooseavatar', e);
},
launchAppError(e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个也连同去掉吧

@@ -59,6 +59,12 @@ const pageObject = {
}
})
},
handleChooseavatar(e) {
console.log('handleChooseavatar', e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里没有从界面显示出来的话,可以加个 showModel 把 url 提示出来

@seasonhuang seasonhuang merged commit 1640fef into wechat-miniprogram:master Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants