Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to hyperlink 4.4.0 #3337

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Upgrade to hyperlink 4.4.0 #3337

merged 2 commits into from
Oct 30, 2019

Conversation

Munter
Copy link
Collaborator

@Munter Munter commented Oct 29, 2019

Hyperlink 4.4.0 has a new feature that will detect broken fragment links of the form /page#fragment where /page is actually a redirect to /page/ because it's a directory with an index file. In this case the server redirect will strip the fragment, thus breaking the intended link.

See errors in the current master branch here: https://travis-ci.org/webpack/webpack.js.org/jobs/604644796#L2041-L2159

The following commit fixes all those errors.

Relates to #3332

@netlify
Copy link

netlify bot commented Oct 29, 2019

Preview is ready

Built with commit ce59a25

https://deploy-preview-3337--webpackjsorg-netlify.netlify.com

@netlify
Copy link

netlify bot commented Oct 29, 2019

Preview is ready

Built with commit d0c271b

https://deploy-preview-3337--webpackjsorg-netlify.netlify.com

@montogeek montogeek merged commit 9b343e7 into master Oct 30, 2019
@montogeek
Copy link
Member

Thank you very much!

@montogeek montogeek deleted the hyperlink-4.4.0 branch October 30, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants