Skip to content

ReSubmit: Add ref-loader to loader's introduction page #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2018
Merged

ReSubmit: Add ref-loader to loader's introduction page #2659

merged 2 commits into from
Nov 20, 2018

Conversation

@leecjson
Copy link
Contributor

@leecjson leecjson commented Nov 20, 2018 •
edited
Loading

Resubmit since #2657

@EugeneHlushko
Copy link
Member

EugeneHlushko commented Nov 20, 2018

Hi @leecjson,

Thanks so much for adding test cases and code comments so that we could also analyze if the package is suspicious or not!

I think its good to go now 👍

@EugeneHlushko EugeneHlushko merged commit 7ed4a62 into webpack:master Nov 20, 2018
@leecjson leecjson deleted the patch-1 branch November 20, 2018 11:42
@leecjson
Copy link
Contributor Author

leecjson commented Nov 21, 2018

Thanks for help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

Assignees

No one assigned

Labels

Loaders

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leecjson @EugeneHlushko