Skip to content

Conversation

@hiroppy
Copy link
Member

@hiroppy hiroppy commented Apr 2, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

This Pr should be merged before other PRs.

                                                                                
                       === npm audit security report ===                        
                                                                                
# Run  npm update handlebars --depth 5  to resolve 1 vulnerability
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ minimist                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ standard-version [dev]                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ standard-version > conventional-changelog >                  │
│               │ conventional-changelog-core > conventional-changelog-writer  │
│               │ > handlebars > optimist > minimist                           │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1179                            │
└───────────────┴──────────────────────────────────────────────────────────────┘

Breaking Changes

Additional Info

@hiroppy hiroppy requested a review from alexander-akait as a code owner April 2, 2020 12:51
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #610 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #610   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files           8        8           
  Lines         228      228           
  Branches       71       71           
=======================================
  Hits          226      226           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ea606...d5f7c66. Read the comment docs.

@hiroppy
Copy link
Member Author

hiroppy commented Apr 2, 2020

@evilebottnawi could you approve this pr?

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead

@hiroppy hiroppy merged commit 1241093 into master Apr 2, 2020
@hiroppy hiroppy deleted the feature/audit branch April 2, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants