refactor: simplify code #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
=========================================
+ Coverage 95.48% 97.08% +1.6%
=========================================
Files 7 7
Lines 310 309 -1
Branches 102 101 -1
=========================================
+ Hits 296 300 +4
+ Misses 11 9 -2
+ Partials 3 0 -3
Continue to review full report at Codecov.
|
hiroppy
reviewed
Sep 28, 2019
| } else { | ||
| if (typeof options.filename === 'string') { | ||
| const filename = options.filename | ||
| .replace(/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\|]/g, '\\$&') // eslint-disable-line no-useless-escape |
Member
Author
There was a problem hiding this comment.
@hiroppy probably already exists, it is just refactor without breaking something, i don't know why it is here 😄, i want to start rewriting this module, so tests will be in near future
hiroppy
approved these changes
Sep 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
just simplify code
Breaking Changes
No
Additional Info
No