Skip to content

Conversation

@hiroppy
Copy link
Member

@hiroppy hiroppy commented Jul 20, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

ref: #439

mime has breaking changes at v2.4.4, so we won't update that version.

 FAIL  test/server.test.js (27.938s)
  ● Server › special file type headers › request to hello.wasm

    Attempt to change mapping for "usdz" extension from "model/vnd.usdz+zip" to "model/vnd.pixar.usd". Pass `force=true` to allow this, otherwise remove "usdz" from
 the list of extensions for "model/vnd.pixar.usd".

      42 |     const typeMap = options.mimeTypes.typeMap || options.mimeTypes;
      43 |     const force = !!options.mimeTypes.force;
    > 44 |     mime.define(typeMap, force);
         |          ^
      45 |   }
      46 | 
      47 |   const context = createContext(compiler, options);

      at Mime.Object.<anonymous>.Mime.define (node_modules/mime/Mime.js:56:15)
      at define (index.js:44:10)
      at Object.<anonymous> (test/server.test.js:418:18)

  ● Server › special file type headers › request to hello.wasm

    expected "Content-Type" of "application/wasm", got "text/html; charset=utf-8"

      at Test.Object.<anonymous>.Test._assertHeader (node_modules/supertest/lib/test.js:249:12)
      at Test.Object.<anonymous>.Test._assertFunction (node_modules/supertest/lib/test.js:283:11)
      at Test.Object.<anonymous>.Test.assert (node_modules/supertest/lib/test.js:173:18)
      at Server.localAssert (node_modules/supertest/lib/test.js:131:12)

  ● Server › special file type headers › request to 3dAr.usdz

    Attempt to change mapping for "usdz" extension from "model/vnd.usdz+zip" to "model/vnd.pixar.usd". Pass `force=true` to allow this, otherwise remove "usdz" from the list of extensions for "model/vnd.pixar.usd".

      42 |     const typeMap = options.mimeTypes.typeMap || options.mimeTypes;
      43 |     const force = !!options.mimeTypes.force;
    > 44 |     mime.define(typeMap, force);
         |          ^
      45 |   }
      46 | 
      47 |   const context = createContext(compiler, options);

      at Mime.Object.<anonymous>.Mime.define (node_modules/mime/Mime.js:56:15)
      at define (index.js:44:10)
      at Object.<anonymous> (test/server.test.js:418:18)

  ● Server › special file type headers › request to 3dAr.usdz

    expected "Content-Type" of "model/vnd.pixar.usd", got "text/html; charset=utf-8"

      at Test.Object.<anonymous>.Test._assertHeader (node_modules/supertest/lib/test.js:249:12)
      at Test.Object.<anonymous>.Test._assertFunction (node_modules/supertest/lib/test.js:283:11)
      at Test.Object.<anonymous>.Test.assert (node_modules/supertest/lib/test.js:173:18)
      at Server.localAssert (node_modules/supertest/lib/test.js:131:12)

Breaking Changes

no

Additional Info

@hiroppy hiroppy requested a review from alexander-akait as a code owner July 20, 2019 14:42
@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #442 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files           7        7           
  Lines         304      304           
  Branches      103      103           
=======================================
  Hits          295      295           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965de1c...cdd86e3. Read the comment docs.

@alexander-akait alexander-akait merged commit 8ec0b3f into master Jul 22, 2019
@alexander-akait alexander-akait deleted the feature/update-deps branch July 22, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants