Skip to content

Conversation

@hiroppy
Copy link
Member

@hiroppy hiroppy commented Apr 3, 2019

What kind of change does this PR introduce?

chore

Did you add tests for your changes?

no

Summary

update eslint and jest.

Does this PR introduce a breaking change?

Other information

@hiroppy hiroppy requested a review from alexander-akait as a code owner April 3, 2019 17:42
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can update some deps too before release next version

@hiroppy
Copy link
Member Author

hiroppy commented Apr 3, 2019

Yep, and I want to add a bot like renovate for updating packages automatically.

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #389 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          13       13           
  Lines         287      287           
  Branches       83       83           
=======================================
  Hits          278      278           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c160b...bbd3236. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #389 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          13       13           
  Lines         287      287           
  Branches       83       83           
=======================================
  Hits          278      278           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c160b...bbd3236. Read the comment docs.

@hiroppy
Copy link
Member Author

hiroppy commented Apr 3, 2019

CI is green, I'm merging.

@hiroppy hiroppy merged commit 6d191d0 into master Apr 3, 2019
@hiroppy hiroppy deleted the feature/update-devdependencies branch April 3, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants