Skip to content

Conversation

@alexander-akait
Copy link
Member

What kind of change does this PR introduce?

refactor

Did you add tests for your changes?

yep

Summary

Migrate on jest

Does this PR introduce a breaking change?

No

Other information

No

@alexander-akait alexander-akait requested a review from hiroppy March 27, 2019 22:46
hiroppy
hiroppy previously approved these changes Mar 27, 2019
Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #386 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #386     +/-   ##
=========================================
- Coverage   96.96%   96.77%   -0.2%     
=========================================
  Files           7       12      +5     
  Lines         264      279     +15     
  Branches        0       82     +82     
=========================================
+ Hits          256      270     +14     
- Misses          8        9      +1
Impacted Files Coverage Δ
test/fixtures/server-test/webpack.array.config.js 100% <0%> (ø)
...xtures/server-test/webpack.client.server.config.js 100% <0%> (ø)
...fixtures/server-test/webpack.querystring.config.js 100% <0%> (ø)
test/fixtures/server-test/webpack.config.js 100% <0%> (ø)
test/fixtures/stat-options.js 90% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba5e02...16f4978. Read the comment docs.

@hiroppy
Copy link
Member

hiroppy commented Mar 27, 2019

Thanks for adding run

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI is green 🍏

@hiroppy
Copy link
Member

hiroppy commented Mar 27, 2019

We should change the number of reviewers with write access for merging.

@hiroppy
Copy link
Member

hiroppy commented Mar 27, 2019

I changed the number of approvers requested to 1.

@hiroppy hiroppy merged commit e6c2b3c into master Mar 27, 2019
@hiroppy hiroppy deleted the chore-migrate-on-jest branch March 27, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants