Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): adding extract css chunks to REAMDME #874

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

ScriptedAlchemy
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Adding it to the documentation as a alternative / extended version of mini-css-extract.
Extract css chunks offers hot module reloading while in development, allowing for good performance on the client and build.
As you guys will know, mini-css is fast, this brings the benefits of it to development without losing the ability to hot reload.

Breaking Changes

None, just docs

Additional Info

With great respect, for you consideration.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash commit in one and use conventional commits, looks good, thanks

@ScriptedAlchemy
Copy link
Contributor Author

Ahhh okay, thank you. Ill do so when i get back on my computer. Appreciate it!

@ScriptedAlchemy
Copy link
Contributor Author

hey @evilebottnawi let me know if this is acceptable :) appreciate the patience!

@alexander-akait
Copy link
Member

@ScriptedAlchemy need fix CI

@alexander-akait
Copy link
Member

@ScriptedAlchemy anyway, we search contributors for mini-css-webpack-plugin, and plugin really looks good, what do you think about union with mini-css-webpack-plugin? We can have one good plugins for css instead of multiple

@ScriptedAlchemy
Copy link
Contributor Author

ScriptedAlchemy commented Dec 20, 2018

i will gladly help with maintainance of mini-css plugin if webpack would be willing to add me as a member/collaborator. I really, really want to get involved with Webpack again and the webpack-contrib group. There are some major performance, memory, and garbage collection upgrades i would like to do.

however, till i can properly discuss this with you and your team, i would like the ReadMe updated as i want to work on a smarter solution that may require collaboration between us.

I used to help you guys out long ago, and my co-auther has written require.requireWeak for you. I want to add value to the overall project and would ask you to take this into consideration. The chance to work with people smarter than myself and learn is amazing, I hope my unique skills can teach some new ideas to the team as well.

If mini-css is a good starting point for trust to be built, then so be it and i will be very happy to be a collaberator. I am very interested in contributing to webpack on multiple fronts as well as learning more from others as well.

@ScriptedAlchemy
Copy link
Contributor Author

ScriptedAlchemy commented Dec 20, 2018

ill address builds issues today. been mobile for a few days.
But would really like to work towards being a part of the webpack contrib group.
I built my career around webpack, and understanding its plugins, loader, and hacks to make it do things it currently is unable.

The oppertunity to work with you guys in some capacity would mean a lot to me.

@ScriptedAlchemy ScriptedAlchemy changed the title docs(readme): Adding extract-css-chunks to REAMDME docs(readme): adding extract css chunks to REAMDME Dec 21, 2018
Adding it to the documentation as a alternative  extended version of mini css extract.
Extract css chunks offers hot module reloading while in development, allowing for good performance on the client and build.
As you guys will know, mini css is fast, this brings the benefits of it to development without losing the ability to hot reload.
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #874 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #874   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          10       10           
  Lines         371      371           
  Branches      105      105           
=======================================
  Hits          369      369           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e233d0a...a533a46. Read the comment docs.

@ScriptedAlchemy
Copy link
Contributor Author

sorry, took me a few attempts to understand the commitlint. super cool by the way, definitely going to adopt that practice.

ill gladly help Webpack team maintain anything they need, and I myself am obsessed with performance. along with the ability to allow many builds to act like one.

to offer some value back to webpack and the community would be really great. I have a deep understanding of webpack architecture and my career is built around architecting billion dollar companies platforms.

I am sure you often get users asking to join, but I believe that my contributions could benefit the project in a positive way.
Let me know what is required, I would definitely love to move towards being a member of webpack-contrib group, and hopefully - one day. the webpack core

With Universal being merged into React, and React Static 6 released and stable. I'll have more time which to allocate so something I am passionate about - webpack. Whatever maintainers you need, count me in! I am not perfect, but I will give you passion and hard work along with my renowned skills in javascript performance optimization

@alexander-akait
Copy link
Member

@ScriptedAlchemy Great news! https://webpack.slack.com/messages/C1LUX2DS9/ invite here and write me, when we invite you private channel. We need more contributors, we have a lot of repo and sometimes and we don't have enouth time on all repo, new contributors welcome, also we fund your work!

@alexander-akait alexander-akait merged commit 60a34d7 into webpack-contrib:master Dec 21, 2018
@ScriptedAlchemy
Copy link
Contributor Author

Oh my gosh! Oh my gosh! Oh my gosh!

This is a dream come true. I have wanted this moment my whole career. Since webpack 1.

You guys/girls have made amazing advances! I’m honored to learn from and help as much as my capabilities can.

Thank you!

@alexander-akait
Copy link
Member

@ScriptedAlchemy Thanks! Wait you in slack 👍

@ScriptedAlchemy
Copy link
Contributor Author

@evilebottnawi i am unable to sign in, what email did you invite with / can you invite with

zack@scriptedalchemy.com

or my personal

zackary.l.jackson@gmail.com

Sorry for inconvenience

@alexander-akait
Copy link
Member

@ScriptedAlchemy please register in slack and send me your nickname to sheo13666q @ gmail.com

@ScriptedAlchemy
Copy link
Contributor Author

ScriptedAlchemy commented Dec 21, 2018

when clicking your link, i get this screen...

I do however have my own slack scriptedalchemy.slack.comand the user is ScriptedAlchemy

This would be zack@ScriptedAlchemy.com

fa3b03fa-907e-4105-8dc4-04d9d7b0c20d

@ScriptedAlchemy
Copy link
Contributor Author

@evilebottnawi I sent a email to the email address you mentioned as well saying similar things. any help would be fantastic. Never seen this issue before

@alexander-akait
Copy link
Member

@ScriptedAlchemy some problems with slack, don't worry i will ping you 👍

@ScriptedAlchemy
Copy link
Contributor Author

Ahhh okay thank you.

This is awesome!

@ScriptedAlchemy
Copy link
Contributor Author

I know holidays are here. And you are busy as ever with your team! From being in open source, I know sometimes things get lost in the emails so will bump over the weekend @evilebottnawi

Have a good holiday season

@alexander-akait
Copy link
Member

@ScriptedAlchemy I have not forgotten about you, don't worry i will ping you, some problem with permission to invite, WIP on this

@ScriptedAlchemy
Copy link
Contributor Author

Ahh yeah thats okay! Let me know if you fellows need anything from me / more information about me for whatever reasons.

HAPPY HOLIDAYS as well!! Don’t forget to take some time with friends and family as new year approaches

@alexander-akait
Copy link
Member

@ScriptedAlchemy Thanks! Just some peoples who have permissions on invite now on holidays, so we need some wait, sorry for this, anyway feel free to start fixing issues 👍

@ScriptedAlchemy
Copy link
Contributor Author

I got the invite from Tobias! I’ll begin migrating and extract css into mini css.

Hopefully some good feedback on better ways to implement the hot reloading solution:) I went on holiday as we were talking. Up in mountains away from computers for the next week. But I’m excited to pitch in once back.

Thanks again

@alexander-akait
Copy link
Member

@ScriptedAlchemy 👍 Feel free to feedback with me in slack, nickname is same as here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants