-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): adding extract css chunks to REAMDME #874
docs(readme): adding extract css chunks to REAMDME #874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash commit in one and use conventional commits, looks good, thanks
Ahhh okay, thank you. Ill do so when i get back on my computer. Appreciate it! |
6bb4da5
to
5fca984
Compare
hey @evilebottnawi let me know if this is acceptable :) appreciate the patience! |
@ScriptedAlchemy need fix CI |
@ScriptedAlchemy anyway, we search contributors for |
i will gladly help with maintainance of mini-css plugin if webpack would be willing to add me as a member/collaborator. I really, really want to get involved with Webpack again and the however, till i can properly discuss this with you and your team, i would like the ReadMe updated as i want to work on a smarter solution that may require collaboration between us. I used to help you guys out long ago, and my co-auther has written require.requireWeak for you. I want to add value to the overall project and would ask you to take this into consideration. The chance to work with people smarter than myself and learn is amazing, I hope my unique skills can teach some new ideas to the team as well. If mini-css is a good starting point for trust to be built, then so be it and i will be very happy to be a collaberator. I am very interested in contributing to webpack on multiple fronts as well as learning more from others as well. |
ill address builds issues today. been mobile for a few days. The oppertunity to work with you guys in some capacity would mean a lot to me. |
Adding it to the documentation as a alternative extended version of mini css extract. Extract css chunks offers hot module reloading while in development, allowing for good performance on the client and build. As you guys will know, mini css is fast, this brings the benefits of it to development without losing the ability to hot reload.
e75dbd2
to
a533a46
Compare
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 10 10
Lines 371 371
Branches 105 105
=======================================
Hits 369 369
Misses 2 2 Continue to review full report at Codecov.
|
sorry, took me a few attempts to understand the commitlint. super cool by the way, definitely going to adopt that practice. ill gladly help Webpack team maintain anything they need, and I myself am obsessed with performance. along with the ability to allow many builds to act like one. to offer some value back to webpack and the community would be really great. I have a deep understanding of webpack architecture and my career is built around architecting billion dollar companies platforms. I am sure you often get users asking to join, but I believe that my contributions could benefit the project in a positive way. With Universal being merged into React, and React Static 6 released and stable. I'll have more time which to allocate so something I am passionate about - webpack. Whatever maintainers you need, count me in! I am not perfect, but I will give you passion and hard work along with my renowned skills in javascript performance optimization |
@ScriptedAlchemy Great news! https://webpack.slack.com/messages/C1LUX2DS9/ invite here and write me, when we invite you private channel. We need more contributors, we have a lot of repo and sometimes and we don't have enouth time on all repo, new contributors welcome, also we fund your work! |
Oh my gosh! Oh my gosh! Oh my gosh! This is a dream come true. I have wanted this moment my whole career. Since webpack 1. You guys/girls have made amazing advances! I’m honored to learn from and help as much as my capabilities can. Thank you! |
@ScriptedAlchemy Thanks! Wait you in slack 👍 |
@evilebottnawi i am unable to sign in, what email did you invite with / can you invite with or my personal Sorry for inconvenience |
@ScriptedAlchemy please register in slack and send me your nickname to sheo13666q @ gmail.com |
when clicking your link, i get this screen... I do however have my own slack This would be zack@ScriptedAlchemy.com |
@evilebottnawi I sent a email to the email address you mentioned as well saying similar things. any help would be fantastic. Never seen this issue before |
@ScriptedAlchemy some problems with slack, don't worry i will ping you 👍 |
Ahhh okay thank you. This is awesome! |
I know holidays are here. And you are busy as ever with your team! From being in open source, I know sometimes things get lost in the emails so will bump over the weekend @evilebottnawi Have a good holiday season |
@ScriptedAlchemy I have not forgotten about you, don't worry i will ping you, some problem with permission to invite, WIP on this |
Ahh yeah thats okay! Let me know if you fellows need anything from me / more information about me for whatever reasons. HAPPY HOLIDAYS as well!! Don’t forget to take some time with friends and family as new year approaches |
@ScriptedAlchemy Thanks! Just some peoples who have permissions on |
I got the invite from Tobias! I’ll begin migrating and extract css into mini css. Hopefully some good feedback on better ways to implement the hot reloading solution:) I went on holiday as we were talking. Up in mountains away from computers for the next week. But I’m excited to pitch in once back. Thanks again |
@ScriptedAlchemy 👍 Feel free to feedback with me in slack, nickname is same as here |
This PR contains a:
Motivation / Use-Case
Adding it to the documentation as a alternative / extended version of mini-css-extract.
Extract css chunks offers hot module reloading while in development, allowing for good performance on the client and build.
As you guys will know, mini-css is fast, this brings the benefits of it to development without losing the ability to hot reload.
Breaking Changes
None, just docs
Additional Info
With great respect, for you consideration.