docs(README): clarify importLoaders usage (options.importLoaders)
#646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joshwiens
approved these changes
Dec 14, 2017
michael-ciniawsky
added
status: Approved
and removed
priority: 5 (nice to have)
severity: 5 (confusing)
labels
michael-ciniawsky
changed the title
importLoaders usage (options.importLoaders)
maxlapides
changed the title
importLoaders usage (options.importLoaders)importLoaders usage (options.importLoaders)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small update to the README. I've spent some time trying to understand how to properly configure the
importLoadersoption, and it seems like this number should always be the number of loaders that precede the thecss-loader. If my understanding is correct, it would make sense to update this example. Otherwise, I think we should add some more documentation here to describe how to choose this number. I would be happy to update this PR with that documentation if someone could give me some more context on what's expected here. Thanks!