Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: practical example for images and fonts #405

Merged
merged 1 commit into from
Mar 6, 2017
Merged

README: practical example for images and fonts #405

merged 1 commit into from
Mar 6, 2017

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Jan 20, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 20, 2017 •
edited by codecov bot
Loading

Codecov Report

Merging #405 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   98.35%   98.45%   +0.09%     
==========================================
  Files           9        9              
  Lines         304      323      +19     
  Branches       67       78      +11     
==========================================
+ Hits          299      318      +19     
  Misses          5        5
Impacted Files Coverage Δ
lib/loader.js 100% <0%> (ø) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9508990...03732c8. Read the comment docs.

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Mar 6, 2017 •
edited
Loading

@simon04 Please close and reopen the PR for CLA

michael-ciniawsky
michael-ciniawsky approved these changes Mar 6, 2017
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thx

@simon04 simon04 closed this Mar 6, 2017
@simon04 simon04 reopened this Mar 6, 2017
@jsf-clabot
Copy link

jsf-clabot commented Mar 6, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bebraw
bebraw approved these changes Mar 6, 2017
View reviewed changes
Copy link
Contributor

@bebraw bebraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after CLA is fine.

@simon04
Copy link
Contributor Author

simon04 commented Mar 6, 2017

CLA signed.

@bebraw bebraw merged commit e4e8239 into webpack-contrib:master Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bebraw bebraw bebraw approved these changes

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

@joshwiens joshwiens Awaiting requested review from joshwiens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simon04 @codecov-io @michael-ciniawsky @jsf-clabot @bebraw