Skip to content

fix: do not crash with 'false' aliases #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 19, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix
  • Loading branch information
alexander-akait committed Apr 19, 2021
commit 9065384f7796310a07d090647a627b3f63a4b993
2 changes: 1 addition & 1 deletion test/fixtures/modules/icss-false-alias/relative.icss.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
:import("/unknown.css") {
:import("./unknown.css") {
IMPORTED_NAME: primary-color;
}

Expand Down
3 changes: 3 additions & 0 deletions test/fixtures/modules/icss-false-alias/unknown.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
:export {
primary-color: red;
}
4 changes: 2 additions & 2 deletions test/modules-option.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -854,9 +854,9 @@ describe('"modules" option', () => {
{
resolve: {
alias: {
"/unknown.css": isWebpack5
"./unknown.css": isWebpack5
? false
: path.resolve(__dirname, "./fixtures/url/logo.png"),
: path.resolve(__dirname, "./fixtures/modules/unknown.css"),
},
},
}
Expand Down