Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: the modules.localsConvention option was renamed to the modules.exportLocalsConvention option #1120

Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Rename options for consistently naming

Breaking Changes

BREAKING CHANGE: the modules.localsConvention option was renamed to the modules.exportLocalsConvention option

Additional Info

No

…odules.exportLocalsConvention` option

BREAKING CHANGE: the `modules.localsConvention` option was renamed to the `modules.exportLocalsConvention` option
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #1120 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1120   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          10       10           
  Lines         607      607           
  Branches      188      188           
=======================================
  Hits          604      604           
  Misses          3        3           
Impacted Files Coverage Δ
src/utils.js 98.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc04401...ebc6850. Read the comment docs.

@alexander-akait alexander-akait merged commit 069dbb0 into master Jul 21, 2020
@alexander-akait alexander-akait deleted the rename-localsConvention-to-exportLocalsConvention branch July 21, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant