-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add exportGlobals
option
#1052
Conversation
Hi @evilebottnawi , Thanks. Sorry. I cannot fix |
@msglight4874 ignore it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation is wrong, need fix
624e019
to
723f3d9
Compare
Hi @evilebottnawi , I fixed document and version in Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
a8a1208
HI @evilebottnawi , Thanks |
@msglight4874 Yes, merge and release will be in near future, need do some improvements for next release |
Ok, thanks. |
Close in favor #1069, we have some conflicts, so as not to wait for fix and do the next release as soon as possible (we have already spent a lot of time on a release), I will send a new PR with more tests, anyway big thanks for helping us and good code |
This PR contains a:
Motivation / Use-Case
This option exports names from global id or class, so we can use the same way like
local
names to reference global names. It will be helpful to switch betweenlocal
andglobal
modes.example:
Breaking Changes
No
Additional Info
Related issues:
#258
Related PRs:
css-modules/postcss-modules-scope#21
Hi @evilebottnawi ,Could you help me to release a new version ofpostcss-modules-scope
package?Then I will update the package version of this PR.Package version updated.
Thanks.