Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structured outputs #78

Merged

Conversation

sushraja-msft
Copy link
Contributor

This change adds support for structured outputs, JSON outputs to the prompt API, following up from issue #35.

We are planning to add support for structured outputs to chromium https://issues.chromium.org/issues/391919456, tracks the dev work in chromium.

@w3cbot
Copy link

w3cbot commented Jan 27, 2025

sushraja-msft marked as non substantive for IPR from ash-nazg.

Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is so exciting.

sushraja-msft marked as non substantive for IPR from ash-nazg.

I think this is a substantive contribution, so probably we should get the permissions figured out so that the W3C understands that you're a member of the WebML CG :)

It says

sushraja-msft is unknown, they need to link their GitHub account with a W3C account.

So maybe you could work on that?

@w3cbot
Copy link

w3cbot commented Jan 28, 2025

domenic marked as substantive for IPR from ash-nazg.

@anssiko
Copy link
Member

anssiko commented Jan 28, 2025

sushraja-msft is unknown, they need to link their GitHub account with a W3C account.

So maybe you could work on that?

@sushraja-msft please follow these instructions to join the Community Group: https://webmachinelearning.github.io/community/#join

Once you do that and check that you've linked your W3C and GH accounts (via Connected accounts) the ipr checker will turn green. Joining the Community Group allows you to contribute to all these incubations:
https://webmachinelearning.github.io/incubations/

You're already in the Working Group and thus can contribute to the WebNN API too. Thanks for your contributions!

@anssiko
Copy link
Member

anssiko commented Jan 28, 2025

@sushraja-msft welcome to the Community Group! The ipr checker is now green. ✅

@sushraja-msft
Copy link
Contributor Author

@domenic, what are the next steps to merge this PR?

Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping. I was unable to continue review over the weekend but will attempt to do so more frequently now.

@sushraja-msft
Copy link
Contributor Author

Thanks for the ping. I was unable to continue review over the weekend but will attempt to do so more frequently now.

no issues, just making sure this PR moves along.

Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one fix. If you think my suggested fix is good as-is, then I can merge on Monday.

@sushraja-msft
Copy link
Contributor Author

LGTM with one fix. If you think my suggested fix is good as-is, then I can merge on Monday.

Yup please merge. Thank you!

@domenic domenic merged commit cbd111e into webmachinelearning:main Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants