Skip to content

Conversation

@shrutikamahale
Copy link
Contributor

@shrutikamahale shrutikamahale commented Sep 11, 2024

PR Title

Removed typos and updated emoji.py script

Summary

Description

The changes are as follows:

-updated emoji.ttf file
-updated read.me

Checks

in the repository

  • Made no changes that degrades the functioning of the repository
  • Gave each commit a better title (unlike updated README.md)

in the PR

  • Followed the format of the pull_request_template
  • Made the Pull Request in a small level (for the creator's wellfare)
  • Tested the changes you made

Thank You,

[Shrutika Mahale]

Copy link
Contributor

@DhanushNehru DhanushNehru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the main Readme.md @shrutikamahale

@shrutikamahale
Copy link
Contributor Author

Thanks for reviewing PR @DhanushNehru , will do the required changes and update the PR

Copy link
Contributor

@DhanushNehru DhanushNehru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shrutikamahale please update the main Readme.md

Under the title List of Scripts in Repo
https://github.com/DhanushNehru/Python-Scripts/blob/master/README.md

@shrutikamahale
Copy link
Contributor Author

Sure @DhanushNehru , Thanks for briefing it. will do the requested changes

@shrutikamahale
Copy link
Contributor Author

shrutikamahale commented Sep 24, 2024

Hi @DhanushNehru I just added README.md file you can see here
master...shrutikamahale:Python-Scripts:patch-2

do I need to create a pull request again? and If yes then can I close existing pull request ??

@DhanushNehru
Copy link
Contributor

Hey @shrutikamahale

Screenshot 2024-09-24 at 1 37 49 PM

I want you to add your script name here in this grid as per alphabetical order. If you have more questions please feel free to join the discord server for further clarifications

@shrutikamahale
Copy link
Contributor Author

Hi @DhanushNehru , Thank you for feedback, I have updated the README.md in List of Scripts. Can you please review it?

Copy link
Contributor

@DhanushNehru DhanushNehru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine @shrutikamahale

@DhanushNehru DhanushNehru merged commit 59db565 into wasmerio:master Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants