Feature/e2e-testing #42
Conversation
| @@ -343,7 +339,7 @@ export class CreateUsers implements SeedsInterface { | |||
| public async seed(factory: FactoryInterface): Promise<any> { | |||
| await factory | |||
| .get(User, 'admin') | |||
| .create(1); | |||
| .create(); | |||
There was a problem hiding this comment.
It would be nice when we could use create(10) and create() so we don't need an additional method createMany(x).
package-scripts.js
Outdated
| 'nps test.e2e.pretest', | ||
| 'nps test.e2e.run' | ||
| ), | ||
| pretest: 'tslint -c ./tslint.json -t stylish ./test/e2e/**/*.ts', |
There was a problem hiding this comment.
Can we refactor this command to be more generic and pass a parameter ./test/e2e/**/*.ts so we can centralise the tslint logic.
| @@ -1,10 +1,14 @@ | |||
| import { FactoryInterface } from './FactoryInterface'; | |||
There was a problem hiding this comment.
Refactor file name to SeedInterfaces.ts as the file exports more than one.
test/e2e/api/users.test.ts
Outdated
| describe('/api/users', () => { | ||
|
|
||
| // ------------------------------------------------------------------------- | ||
| // Tear up |
test/e2e/utils/typeormLoader.ts
Outdated
| @@ -0,0 +1,15 @@ | |||
| import { createDatabaseConnection } from './../../integration/utils/database'; | |||
There was a problem hiding this comment.
Probably we should isolate integration tests from e2d tests?
test/e2e/api/info.test.ts
Outdated
| @@ -0,0 +1,38 @@ | |||
| import { Application } from 'express'; | |||
There was a problem hiding this comment.
I think it's unused. Please fix your tslint or ts => https://palantir.github.io/tslint/rules/no-unused-variable/
test/e2e/api/users.test.ts
Outdated
| @@ -0,0 +1,66 @@ | |||
| import * as nock from 'nock'; | |||
| import * as request from 'supertest'; | |||
| import { Application } from 'express'; | |||
There was a problem hiding this comment.
I think it's unused. Please fix your tslint or ts => https://palantir.github.io/tslint/rules/no-unused-variable/
test/e2e/utils/bootstrap.ts
Outdated
| import { monitorLoader } from './../../../src/loaders/monitorLoader'; | ||
| import { homeLoader } from './../../../src/loaders/homeLoader'; | ||
| import { typeormLoader } from '../utils/typeormLoader'; | ||
| import { publicLoader } from './../../../src/loaders/publicLoader'; |
There was a problem hiding this comment.
I think it's unused. Please fix your tslint or ts => https://palantir.github.io/tslint/rules/no-unused-variable/
test/e2e/utils/bootstrap.ts
Outdated
| import { monitorLoader } from './../../../src/loaders/monitorLoader'; | ||
| import { homeLoader } from './../../../src/loaders/homeLoader'; | ||
| import { typeormLoader } from '../utils/typeormLoader'; | ||
| import { publicLoader } from './../../../src/loaders/publicLoader'; |
test/e2e/utils/typeormLoader.ts
Outdated
| import { Connection } from 'typeorm/connection/Connection'; | ||
| import { createConnection } from 'typeorm'; | ||
| import { MicroframeworkSettings, MicroframeworkLoader } from 'microframework-w3tec'; | ||
| import { env } from '../../../src/core/env'; |
There was a problem hiding this comment.
I think it's unused. Please fix your tslint or ts => https://palantir.github.io/tslint/rules/no-unused-variable/
No description provided.