BugFix - Added missing connectionName. #118
Conversation
|
|
||
| if ($message instanceof AMQPMessage) { | ||
| return new RabbitMQJob($this->container, $this, $this->channel, $queue, $message); | ||
| return new RabbitMQJob($this->container, $this, $this->channel, $queue, $message, $this->connectionName); |
There was a problem hiding this comment.
Line exceeds 120 characters; contains 121 characters
|
|
||
| if ($message instanceof AMQPMessage) { | ||
| return new RabbitMQJob($this->container, $this, $this->channel, $queue, $message); | ||
| return new RabbitMQJob($this->container, $this, $this->channel, |
There was a problem hiding this comment.
Opening parenthesis of a multi-line function call must be the last content on the line
Only one argument is allowed per line in a multi-line function call
| if ($message instanceof AMQPMessage) { | ||
| return new RabbitMQJob($this->container, $this, $this->channel, $queue, $message); | ||
| return new RabbitMQJob($this->container, $this, $this->channel, | ||
| $queue, $message, $this->connectionName); |
There was a problem hiding this comment.
Multi-line function call not indented correctly; expected 16 spaces but found 20
Only one argument is allowed per line in a multi-line function call
Closing parenthesis of a multi-line function call must be on a line by itself
|
@vladimir-yuldashev will you move the 5.4 tag to include this? |
|
@sazo Yes, a bit later as soon I will get to my computer. Did you test that driver still works? 😂 |
|
@vladimir-yuldashev Np - yeah i tested it on our development environment ;) |
|
love the driver btw! :) |
|
@sazo Released. |
3 participants
When calling $this->fail() inside a RabbitMQ job it fails because the connectionName is NULL.
I have looked at how core laravel jobs does it and this is how. :)
Next exception 'Illuminate\Database\QueryException' with message 'SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'connection' cannot be null (SQL: insert into failed_jobs (connection, queue, payload, exception, failed_at) .....